[Review Request]: Patch for Adaptive RED implementation in ns-3.24

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[Review Request]: Patch for Adaptive RED implementation in ns-3.24

Mohit P. Tahiliani
Hello,

This is a review request for a patch that provides an implementation of
Adaptive RED (ARED) in  ns-3.24.

All features mentioned in the Adaptive RED paper [1] have been implemented.

Patch and further details are available here:
https://codereview.appspot.com/279950043/

Any suggestion/review would be much appreciated.

Thanks and Regards,
Mohit P. Tahiliani

[1] http://www.icir.org/floyd/papers/adaptiveRed.pdf
Reply | Threaded
Open this post in threaded view
|

Re: [Review Request]: Patch for Adaptive RED implementation in ns-3.24

Natale Patriciello
On 21/11/15 at 09:31am, Mohit P. Tahiliani wrote:
> Hello,

Hi Mohit, let me thank you for your effort on that!

> This is a review request for a patch that provides an implementation of
> Adaptive RED (ARED) in  ns-3.24.
>
> All features mentioned in the Adaptive RED paper [1] have been implemented.
>
> Patch and further details are available here:
> https://codereview.appspot.com/279950043/

I've done an initial review for such code; it looks good, there are some
minor comments on attribute and value checking.
With these fixed, I think it is really close to be inserted in the
mainline, since ARed is a cool feature.

I wonder if you have given a look to my Queue patch, where (basically) I
uniform the Queue interfaces through the users, in terms of occupancy
and statistics, and what do you think about that.

Nat
Reply | Threaded
Open this post in threaded view
|

Re: [Review Request]: Patch for Adaptive RED implementation in ns-3.24

Mohit P. Tahiliani
In reply to this post by Mohit P. Tahiliani
Dear Nat,

Thank you very much for taking out time to review the patch.

I have made all the changes as suggested.

A few suggestions made by Tom Sir are yet to be incorporated. I will upload
the corrected patch soon.

About the Queue patch - I haven't looked at it yet, but I am very much
interested to look into it. I shall do that over this weekend.

Thanks again!

Regards,
Mohit P. Tahiliani

On Thu, Dec 3, 2015 at 6:30 AM, <[hidden email]> wrote:

> Send Ns-developers mailing list submissions to
>         [hidden email]
>
> To subscribe or unsubscribe via the World Wide Web, visit
>         http://mailman.isi.edu/mailman/listinfo/ns-developers
> or, via email, send a message with subject or body 'help' to
>         [hidden email]
>
> You can reach the person managing the list at
>         [hidden email]
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of Ns-developers digest..."
>
>
> Today's Topics:
>
>    1. Re: [Review Request]: Patch for Adaptive RED implementation
>       in ns-3.24 (Natale Patriciello)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Wed, 2 Dec 2015 10:44:07 +0100
> From: Natale Patriciello <[hidden email]>
> Subject: Re: [Ns-developers] [Review Request]: Patch for Adaptive RED
>         implementation in ns-3.24
> To: "Mohit P. Tahiliani" <[hidden email]>
> Cc: [hidden email]
> Message-ID: <20151202094407.GA21029@miyamoto>
> Content-Type: text/plain; charset=us-ascii
>
> On 21/11/15 at 09:31am, Mohit P. Tahiliani wrote:
> > Hello,
>
> Hi Mohit, let me thank you for your effort on that!
>
> > This is a review request for a patch that provides an implementation of
> > Adaptive RED (ARED) in  ns-3.24.
> >
> > All features mentioned in the Adaptive RED paper [1] have been
> implemented.
> >
> > Patch and further details are available here:
> > https://codereview.appspot.com/279950043/
>
> I've done an initial review for such code; it looks good, there are some
> minor comments on attribute and value checking.
> With these fixed, I think it is really close to be inserted in the
> mainline, since ARed is a cool feature.
>
> I wonder if you have given a look to my Queue patch, where (basically) I
> uniform the Queue interfaces through the users, in terms of occupancy
> and statistics, and what do you think about that.
>
> Nat
>
>
> ------------------------------
>
> _______________________________________________
> Ns-developers mailing list
> [hidden email]
> http://mailman.isi.edu/mailman/listinfo/ns-developers
>
>
> End of Ns-developers Digest, Vol 109, Issue 1
> *********************************************
>